Opened 15 years ago

Closed 15 years ago

#324 closed defect (fixed)

Flow conservation error

Reported by: ted Owned by: steve
Priority: highest Milestone:
Component: Functionality and features Version: 1.0
Severity: critical Keywords:
Cc: ole

Description

There is a problem with conservation of flow and match between domain depth and depth derived from Manning's equation. A test for this was added in changeset:6643. It is unclear as yet, but flow conservation seems to be sensitive to surface slope and Manning's n, raising concern as to the way friction is handled in the model. Additionally, it is noted that there is currently no mass balance check on the model. This is an important check in all hydrodynamic models and should be added to ANUGA. Such a check could shed further light on the flow conservation problem noted above.

Change History (3)

comment:1 Changed 15 years ago by ole

  • Component changed from Appearance and visualisation to Functionality and features

comment:2 Changed 15 years ago by ole

First pass volumetric report created in changeset:6654. Usage: print domain.volumetric_balance_statistics()

This function will print out flows across boundaries and total instantaneous volume in domain. Flows due to forcing terms have not yet been implemented.

The last test in test_shallow_water_domain.py called test_friction_dependent_flow_using_flowline() reveals the issues with flows and manning friction without using forcing terms, so that in conjunction with volumetric_balance_statistics() should be enough to investigate this problem.

The test is disabled with an 'X' to avoid output in test_all.py

comment:3 Changed 15 years ago by ole

  • Resolution set to fixed
  • Status changed from new to closed

This was due to insufficient running time and was addressed in changeset:6659, changeset:6705, changeset:6729 and changeset:6763

Note: See TracTickets for help on using tickets.