| 1 | |
|---|
| 2 | OPEN ISSUES: |
|---|
| 3 | ------------ |
|---|
| 4 | |
|---|
| 5 | |
|---|
| 6 | Issue: Exceptions thrown by Python functions called from C don't get caughts |
|---|
| 7 | Background: Have a look at gravity in shallow_water. It calls a C function, gradient, which may throw an exception if arguments are scalars. |
|---|
| 8 | However, it doesn't get caught becuase gravity itself is called from within C |
|---|
| 9 | Importance: Mid |
|---|
| 10 | Suggested Action: Have a look at the calling convention from C (David Beasley) |
|---|
| 11 | Status: Unresolved |
|---|
| 12 | |
|---|
| 13 | |
|---|
| 14 | Issue: Parameters specified in config.py must be tranferred to C code |
|---|
| 15 | and it should be possible to override them when setting up a domain. |
|---|
| 16 | Background: N/A |
|---|
| 17 | Importance: Mid |
|---|
| 18 | Suggested Action: |
|---|
| 19 | 1: Let domain read the config file to provide default values. |
|---|
| 20 | 2: Write getters and setters to override them. |
|---|
| 21 | 3: Pass pertinent values from domain into the c-extensions. |
|---|
| 22 | Status: Unresolved, D+O agreed to do it this way 18/5 |
|---|
| 23 | |
|---|
| 24 | |
|---|
| 25 | Issue: Checkpointing - needs to respect changes in script. |
|---|
| 26 | |
|---|
| 27 | |
|---|
| 28 | Issue: Adding unknown quantities cause a KeyError. Known quantities |
|---|
| 29 | are given in the list other_quantities, in shallow_water. Do we want |
|---|
| 30 | unknown quantities attached to domain in the future? If so, it |
|---|
| 31 | shouldn't cause a key error. |
|---|
| 32 | Importance: low |
|---|
| 33 | Suggested Action: |
|---|
| 34 | |
|---|
| 35 | |
|---|
| 36 | Issue: The water level can not be less than the bed elevation, as an |
|---|
| 37 | assert. |
|---|
| 38 | Importance: Medium |
|---|
| 39 | Suggested Action: How about having the functionality that water levels are set |
|---|
| 40 | to == the bed elevation, if level < bed elevation. This will make |
|---|
| 41 | setting things up easier. |
|---|
| 42 | |
|---|
| 43 | |
|---|
| 44 | Issue: Transmissive boundary condition can cause unphysical momentums if |
|---|
| 45 | material is not moving out of the domain. |
|---|
| 46 | Importance: Med |
|---|
| 47 | Suggested Action: Add some sort of warning in (subclass of) Transmissive_boundary |
|---|
| 48 | alerting inflow of material. |
|---|
| 49 | |
|---|
| 50 | |
|---|
| 51 | |
|---|
| 52 | CLOSED ISSUES: |
|---|
| 53 | -------------- |
|---|
| 54 | |
|---|
| 55 | |
|---|
| 56 | Issue (Malpasset example): |
|---|
| 57 | Pmesh no longer takes care of attributes but still accepts xya with attributes. |
|---|
| 58 | |
|---|
| 59 | Background: |
|---|
| 60 | Chris imported xya file into pmesh. It contained x, y, bed elevation |
|---|
| 61 | The tsh thus generated did add bed elevation, but didn't produce the proper |
|---|
| 62 | tsh file. |
|---|
| 63 | |
|---|
| 64 | Importance: mid |
|---|
| 65 | Suggested actions: Either spit out an error message or generate a proper |
|---|
| 66 | tsh-header. |
|---|
| 67 | Status: The story of this is wrong. Pmesh does produce a proper tsh file |
|---|
| 68 | |
|---|
| 69 | Issue: Second order limiters may cause numerical problems |
|---|
| 70 | manifesting themselves as QNAN (Quiet NANs_ or INF) |
|---|
| 71 | Background: The second order gradient limiter is not robust enough - |
|---|
| 72 | especially with shallow water depths. Heighs and momentum are |
|---|
| 73 | limited independently and high speeds may result. |
|---|
| 74 | Importance: Mid |
|---|
| 75 | Suggested Action: |
|---|
| 76 | 1: Try to incorporate a weighted averaging process between |
|---|
| 77 | shallow depths and large depths as in the first order scheme. |
|---|
| 78 | 2: Look at limiting height and momentum together, by keeping |
|---|
| 79 | an eye on the speeds |
|---|
| 80 | (e.g make speed constant across a volume and recompute momentum) |
|---|
| 81 | 3: Catch errors resulting from these instabilities as early |
|---|
| 82 | as possibly and produce and throw an appropriate exception |
|---|
| 83 | 4: Make small example that reveals this bug. |
|---|
| 84 | Status: 1 succesfully implemented by Ole and Stephen 12/5/4. |
|---|
| 85 | 2 Didn't work but using the weighted average for momentums seemed |
|---|
| 86 | to work well. |
|---|
| 87 | 3 and 4 not done. |
|---|
| 88 | June 2004: With the new limiter (item 1 and 2) 3 and 4 are probably |
|---|
| 89 | not necessary now. |
|---|
| 90 | |
|---|
| 91 | |
|---|
| 92 | |
|---|
| 93 | Issue: Tags for specifying boundary conditions should be arbitrary |
|---|
| 94 | Background: Domain has the functionality for using arbitrary keys |
|---|
| 95 | when associating boundary objects to boundary values. |
|---|
| 96 | Triangle, which pmesh is based on, uses integers only. |
|---|
| 97 | It would be nice to have mnemonic names for boundaries throughout. |
|---|
| 98 | Importance: Mid |
|---|
| 99 | Status: Duncan resolved this in early June. |
|---|
| 100 | |
|---|
| 101 | |
|---|
| 102 | |
|---|
| 103 | |
|---|
| 104 | Issue: Checkpointing - needs to always back one timestep up in |
|---|
| 105 | case output wasn't written |
|---|
| 106 | Background: |
|---|
| 107 | Data at latest checkpoint may be incomplete or even corrupted |
|---|
| 108 | depending on when and how program was stopped. |
|---|
| 109 | Importance: Mid |
|---|
| 110 | Suggested Action: Always try second latest checkpoint first. |
|---|
| 111 | Status: Done (Ole 14/5/4) |
|---|
| 112 | |
|---|
| 113 | |
|---|
| 114 | |
|---|
| 115 | Issue: interpolated_conserved_quantities in shallow_water.py |
|---|
| 116 | Background: Was computed by flux functions and used by bed_slope. |
|---|
| 117 | It turns out to be unneccessary as conserved quantities at centroid works just as well. |
|---|
| 118 | Importance: Mid |
|---|
| 119 | Suggested Action: Get rid of it everywhere |
|---|
| 120 | Status: Was done when whole things was refactored in April 2004 by OMN |
|---|
