| 1 | |
|---|
| 2 | OPEN ISSUES: |
|---|
| 3 | ------------ |
|---|
| 4 | Issue (interpolate_sww): Give a warning if points are outside the mesh. |
|---|
| 5 | Importance: Mid |
|---|
| 6 | Who: DSG |
|---|
| 7 | |
|---|
| 8 | Issue (interpolate_sww (new functionality)): Be able to specify at |
|---|
| 9 | what times data is needed e.g. input a start, finish and period. |
|---|
| 10 | Importance: low |
|---|
| 11 | |
|---|
| 12 | Issue (least_squares): Do a test that the number of attribute titles and number |
|---|
| 13 | of attributes match |
|---|
| 14 | Importance: Mid |
|---|
| 15 | Who: DSG |
|---|
| 16 | |
|---|
| 17 | Issue (least_squares): Do a bug report ot sci py |
|---|
| 18 | Importance: low to don't do |
|---|
| 19 | Who: Stephen |
|---|
| 20 | |
|---|
| 21 | Issue (least_squares): datapoints outside the mesh are not used in |
|---|
| 22 | least squares. |
|---|
| 23 | Importance: Mid - low |
|---|
| 24 | Suggested Action: Talk to Steve about including them |
|---|
| 25 | |
|---|
| 26 | Issue (least_squares): Code to not product D matrix (if it isn't |
|---|
| 27 | needed) isn't working. |
|---|
| 28 | Importance: Mid - low |
|---|
| 29 | Suggested Action: Fix |
|---|
| 30 | |
|---|
| 31 | Issue: Get the reservoir example working for the 'new' pyvolution |
|---|
| 32 | Issue: Mid |
|---|
| 33 | Who: DSG |
|---|
| 34 | |
|---|
| 35 | Issue: Exceptions thrown by Python functions called from C don't get caughts |
|---|
| 36 | Background: Have a look at gravity in shallow_water. It calls a C function, gradient, which may throw an exception if arguments are scalars. |
|---|
| 37 | However, it doesn't get caught becuase gravity itself is called from within C |
|---|
| 38 | Importance: Low |
|---|
| 39 | Suggested Action: Have a look at the calling convention from C (David Beasley) |
|---|
| 40 | Status: Unresolved |
|---|
| 41 | |
|---|
| 42 | |
|---|
| 43 | Issue: Parameters specified in config.py must be tranferred to C code |
|---|
| 44 | and it should be possible to override them when setting up a domain. |
|---|
| 45 | Background: N/A |
|---|
| 46 | Importance: Mid |
|---|
| 47 | Suggested Action: |
|---|
| 48 | 1: Let domain read the config file to provide default values. |
|---|
| 49 | 2: Write getters and setters to override them. |
|---|
| 50 | 3: Pass pertinent values from domain into the c-extensions. |
|---|
| 51 | Status: Largely resolved. action 2 ongoing |
|---|
| 52 | |
|---|
| 53 | |
|---|
| 54 | Issue: Checkpointing - needs to respect changes in script. |
|---|
| 55 | Importance: Low |
|---|
| 56 | |
|---|
| 57 | |
|---|
| 58 | Issue: Adding unknown quantities cause a KeyError. Known quantities |
|---|
| 59 | are given in the list other_quantities, in shallow_water. Do we want |
|---|
| 60 | unknown quantities attached to domain in the future? If so, it |
|---|
| 61 | shouldn't cause a key error. |
|---|
| 62 | Importance: low |
|---|
| 63 | Suggested Action: |
|---|
| 64 | Who: OLE |
|---|
| 65 | |
|---|
| 66 | |
|---|
| 67 | Issue: The water level can not be less than the bed elevation, as an |
|---|
| 68 | assert. |
|---|
| 69 | Importance: Medium |
|---|
| 70 | Suggested Action: How about having the functionality that water levels are set |
|---|
| 71 | to == the bed elevation, if level < bed elevation. This will make |
|---|
| 72 | setting things up easier. A following suggestion is don't initialise |
|---|
| 73 | quantities without values, eg in quantity __init__. |
|---|
| 74 | Status: resolved. Needs unit test though |
|---|
| 75 | |
|---|
| 76 | Issue: Transmissive boundary condition can cause unphysical momentums if |
|---|
| 77 | material is not moving out of the domain. |
|---|
| 78 | Importance: Med |
|---|
| 79 | Suggested Action: Comment in transmissive boundary code. look into |
|---|
| 80 | sponge boundary. |
|---|
| 81 | |
|---|
| 82 | |
|---|
| 83 | |
|---|
| 84 | |
|---|
| 85 | CLOSED ISSUES: |
|---|
| 86 | -------------- |
|---|
| 87 | |
|---|
| 88 | |
|---|
| 89 | Issue (Malpasset example): |
|---|
| 90 | Pmesh no longer takes care of attributes but still accepts xya with attributes. |
|---|
| 91 | |
|---|
| 92 | Background: |
|---|
| 93 | Chris imported xya file into pmesh. It contained x, y, bed elevation |
|---|
| 94 | The tsh thus generated did add bed elevation, but didn't produce the proper |
|---|
| 95 | tsh file. |
|---|
| 96 | |
|---|
| 97 | Importance: mid |
|---|
| 98 | Suggested actions: Either spit out an error message or generate a proper |
|---|
| 99 | tsh-header. |
|---|
| 100 | Status: The story of this is wrong. Pmesh does produce a proper tsh file |
|---|
| 101 | |
|---|
| 102 | Issue: Second order limiters may cause numerical problems |
|---|
| 103 | manifesting themselves as QNAN (Quiet NANs_ or INF) |
|---|
| 104 | Background: The second order gradient limiter is not robust enough - |
|---|
| 105 | especially with shallow water depths. Heighs and momentum are |
|---|
| 106 | limited independently and high speeds may result. |
|---|
| 107 | Importance: Mid |
|---|
| 108 | Suggested Action: |
|---|
| 109 | 1: Try to incorporate a weighted averaging process between |
|---|
| 110 | shallow depths and large depths as in the first order scheme. |
|---|
| 111 | 2: Look at limiting height and momentum together, by keeping |
|---|
| 112 | an eye on the speeds |
|---|
| 113 | (e.g make speed constant across a volume and recompute momentum) |
|---|
| 114 | 3: Catch errors resulting from these instabilities as early |
|---|
| 115 | as possibly and produce and throw an appropriate exception |
|---|
| 116 | 4: Make small example that reveals this bug. |
|---|
| 117 | Status: 1 succesfully implemented by Ole and Stephen 12/5/4. |
|---|
| 118 | 2 Didn't work but using the weighted average for momentums seemed |
|---|
| 119 | to work well. |
|---|
| 120 | 3 and 4 not done. |
|---|
| 121 | June 2004: With the new limiter (item 1 and 2) 3 and 4 are probably |
|---|
| 122 | not necessary now. |
|---|
| 123 | |
|---|
| 124 | |
|---|
| 125 | |
|---|
| 126 | Issue: Tags for specifying boundary conditions should be arbitrary |
|---|
| 127 | Background: Domain has the functionality for using arbitrary keys |
|---|
| 128 | when associating boundary objects to boundary values. |
|---|
| 129 | Triangle, which pmesh is based on, uses integers only. |
|---|
| 130 | It would be nice to have mnemonic names for boundaries throughout. |
|---|
| 131 | Importance: Mid |
|---|
| 132 | Status: Duncan resolved this in early June. |
|---|
| 133 | |
|---|
| 134 | |
|---|
| 135 | |
|---|
| 136 | |
|---|
| 137 | Issue: Checkpointing - needs to always back one timestep up in |
|---|
| 138 | case output wasn't written |
|---|
| 139 | Background: |
|---|
| 140 | Data at latest checkpoint may be incomplete or even corrupted |
|---|
| 141 | depending on when and how program was stopped. |
|---|
| 142 | Importance: Mid |
|---|
| 143 | Suggested Action: Always try second latest checkpoint first. |
|---|
| 144 | Status: Done (Ole 14/5/4) |
|---|
| 145 | |
|---|
| 146 | |
|---|
| 147 | |
|---|
| 148 | Issue: interpolated_conserved_quantities in shallow_water.py |
|---|
| 149 | Background: Was computed by flux functions and used by bed_slope. |
|---|
| 150 | It turns out to be unneccessary as conserved quantities at centroid works just as well. |
|---|
| 151 | Importance: Mid |
|---|
| 152 | Suggested Action: Get rid of it everywhere |
|---|
| 153 | Status: Was done when whole things was refactored in April 2004 by OMN |
|---|
