Changeset 4768

Timestamp:

Oct 30, 2007, 1:12:45 PM (17 years ago)

Author:

ole

Message:

Backlog of comments and errormessages

Files:

• anuga_core/source/anuga/abstract_2d_finite_volumes/quantity.py (modified) (2 diffs)
• anuga_core/source/anuga/config.py (modified) (1 diff)
• anuga_core/source/anuga/utilities/polygon.py (modified) (2 diffs)
• anuga_validation/performance_tests/okushiri/run_okushiri_profile.py (modified) (1 diff)
• anuga_work/publications/anuga_2007/anuga_validation.tex (modified) (1 diff)
• anuga_work/publications/ausgeo_2004/AusGeo 2004.doc (modified) (previous)

anuga_core/source/anuga/abstract_2d_finite_volumes/quantity.py

@@ -527 +527 @@
         if indices is not None:
             indices = array(indices).astype(Int)
-            msg = 'Number of values must match number of indices'
+            msg = 'Number of values must match number of indices:'
+            msg += 'You specified %d values and %d indices'\
+                   %(values.shape[0], indices.shape[0])
             assert values.shape[0] == indices.shape[0], msg
 
@@ -996 +998 @@
         The values will be stored in elements following their
         internal ordering.
-
         """
         from Numeric import take
+
+        # FIXME (Ole): I reckon we should have the option of passing a
+        #              polygon into get_values. The question becomes how
+        #              resulting values should be ordered.
 
         if interpolation_points is not None:

anuga_core/source/anuga/config.py

@@ -65 +65 @@
 # stationary water 'lapping' upwards to a higher point on the coast.
 #
-#
-#
+# NOTE (Ole): I believe this was addressed with the introduction of
+# tight_slope_limiters. I wish to retire the beta_? parameters.
+# Can you please let me know if you disagree?
+
+
 #There are separate betas for the w, uh, vh and h limiters
 #

anuga_core/source/anuga/utilities/polygon.py

@@ -80 +80 @@
         raise NameError, e
     except:
-        # FIXME(Ole): This message is wrong. Shouldn't it be "Absolute"
-        # rather than "Numeric"?
-        # (DSG)  If this fails it is going to be because the points can't be
-        # converted to a numeric array.  So this error message is good.
+        # If this fails it is going to be because the points can't be
+        # converted to a numeric array.
         msg = 'Points could not be converted to Numeric array' 
         raise msg
@@ -92 +90 @@
         raise NameError, e
     except:
-        # FIXME(Ole): This message is wrong. Shouldn't it be "Absolute"
-        # rather than "Numeric"?
-         # (DSG)  If this fails it is going to be because the points can't be
-        # converted to a numeric array.  So this error message is good.
+        # If this fails it is going to be because the points can't be
+        # converted to a numeric array.
         msg = 'Polygon %s could not be converted to Numeric array' %(str(polygon))
         raise msg

anuga_validation/performance_tests/okushiri/run_okushiri_profile.py

@@ -100 +100 @@
 #s = S.sort_stats('cumulative').print_stats(30)
 
+s.print_callers()
 print s
 

anuga_work/publications/anuga_2007/anuga_validation.tex

@@ -85 +85 @@
 
 
-\ANUGA{} is availbale as Open Source to enable
+\ANUGA{} is available as Open Source to enable
 free access to the software and allow the scientific community to
 use, validate and contribute to the software in the future.