Changeset 905

Timestamp:

Feb 17, 2005, 11:51:58 AM (20 years ago)

Author:

duncan

Message:

comments

File:

• inundation/ga/storm_surge/pyvolution/pmesh2domain.py (modified) (2 diffs)

inundation/ga/storm_surge/pyvolution/pmesh2domain.py

@@ -33 +33 @@
     #(when I get around to it) so it should be removed from here.  
     
+    # This doesn't work on the domain instance.
+    # This is still needed so -ve elevations don't cuase 'lakes'
+    # The fixme we discussed was to only create a quantity when its values are set.
+    # I think that's the way to go still
+    
     # set the water stage to be the elevation
-    # This doesn't work on the domain instance.
     if vertex_quantity_dict.has_key('elevation') and not vertex_quantity_dict.has_key('stage'):
         vertex_quantity_dict['stage'] = vertex_quantity_dict['elevation']
+        
     domain.set_quantity_vertices_dict(vertex_quantity_dict)
     #print "vertex_quantity_dict",vertex_quantity_dict
@@ -102 +107 @@
 #instead of having to be created here?
 
+#This information is pyvolution focused, not mesh generation focused.
+#This is an appropriate place for the info to be created. -DSG
+
 #FIXME: Another issue is that the tsh file stores consecutive
 #indices explicitly. This is really redundant.
 #Suggest looking at obj and our own sww format and also consider
 #using netCDF.
+
+# It is redundant.  It was the format originally decided on.
+# I'm happy for it to change. -DSG
 
 def pmesh_dict_to_marker_dict(mesh_dict):