Changeset 5878 for anuga_core/source/anuga/shallow_water/test_system.py

Timestamp:

Oct 30, 2008, 12:20:50 PM (16 years ago)

Author:

ole

Message:

Fixed unit test that broke between changeset:5846 and changeset:5847

I have convinced myself that the problem was that although the test passed
it was wrong.
In changeset:5846 it is clear that the time boundary in the helper function
create_sww_boundary was not evaluated correctly as domain.time got updated
after the call to update_boundary in domain.py.
This caused the boundary evaluation to lag.

However, this lag was not present originally in ANUGA so this error
would have been introduced
somewhere along with the euler stepping - most likely around November 2007.

I added an assert checking that the lag is not present now or in the future.

File:

• anuga_core/source/anuga/shallow_water/test_system.py (modified) (3 diffs)

anuga_core/source/anuga/shallow_water/test_system.py

@@ -60 +60 @@
         for t in domain.evolve(yieldstep = 10, finaltime = 20.0):
             pass
+            #print domain.boundary_statistics('stage')
+            q = Bd.evaluate()
+    
+            # FIXME (Ole): This test would not have passed in 
+            # changeset:5846.
+            msg = 'Time boundary not evaluated correctly'
+            assert allclose(t, q[0]), msg
+            
+            #print domain.get_quantity('stage').get_values()
             #domain.write_time()
             #print "domain.time", domain.time
+            
         return boundary_filename
     
@@ -150 +160 @@
         for t in domain.evolve(yieldstep = 5, finaltime = 9.0):
             pass
+            #print domain.boundary_statistics()
             #domain.write_time()
             #print "domain.time", domain.time
@@ -162 +173 @@
         assert allclose(fid.starttime, new_starttime)
         fid.close()
+        
         #print "stage[2,0]", stage[2,0]
         msg = "This test is a bit hand crafted, based on the output file. "
         msg += "Not logic. "
         msg += "It's testing that starttime is working"
-        assert allclose(stage[2,0], 5.959411),msg
+        assert allclose(stage[2,0], 11.9867153168),msg