Opened 15 years ago

Closed 15 years ago

#173 closed enhancement (fixed)

Time series plots have incorrect starttimes

Reported by: nick Owned by: nick
Priority: high Milestone:
Component: Functionality and features Version:
Severity: minor Keywords:
Cc:

Description

In some of the scenarios to increase speed on the model, i have remove X seconds from begining of the boundary sww file when it was created in "urs_ungridded2sww" using "mint" and "maxt". Generally because the wave would arrive after 4 hours therefore removing 1-1.5 hours speeds up the program.

It would be great if "mint" eg 4000 secs was recorded as the first time step in the resulting sww file. In the model script the boundary file is loaded using "Field_boundary"

This carrying of "mint" info through to the final evolved sww is mainly important in the generation of the time_series plots which currently require to manually input the correct "mint" into the function.... which has lead to errors and wasted time.

Change History (5)

comment:1 Changed 15 years ago by ole

The variable domain.starttime is recorded in our sww files just as xllcorner and yllcorner are.

The first timestep in sww is always 0, but this is relative to starttime, so it is entirely possible to say that the stored model starts at 4000s.

The current viewer does not show the model time + startime, but otherwise it is all there.

comment:2 Changed 15 years ago by ole

There is no compelling reason for sww files to be relative to starttime so I think we should try storing time as absolute values.

I suggest, someone goes to store_timestep in data_manager.py and add domain.starttime to domain.time whereever the time is assigned to the netcdf array.

There might be a little fiddle with the code that checks if the file has become too large, but otherwise it should be simple.

The Anuga viewer should also work, but this needs to be tested.

comment:3 Changed 15 years ago by duncan

  • Summary changed from Time recorded in Sww file should include domain.starttime (i don't think it is at the moment) to Time series plots have incorrect starttimes

Sww files were made to have absolute timesets in changeset[4550]. This caused the errors in ticket#174

Now is not the time to change how anuga works with time. changeset[4550] has been removed, changeset[4558].

Focus on the generation of the time_series plots to work out why the starttime isn't carried thru.

comment:4 Changed 15 years ago by duncan

  • Owner changed from Duncan to nick

Nick, could you make sure that the starttime value which is in the sww file is carried over into the plot. That will fix this error.

comment:5 Changed 15 years ago by nick

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.