Opened 18 years ago
Last modified 16 years ago
#223 reopened defect
sww2domain is failing in (DISABLED)test_sww2domain2
| Reported by: | ole | Owned by: | ole |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | Testing and validation | Version: | |
| Severity: | minor | Keywords: | |
| Cc: |
Description
Currently the parameter minimum_storable_height controls the smallest depth ANUGA is willing to store. However, Rudy van Drie noticed that momenta are stored for depths smaller than that resulting in sww files that have regions with nonzero momentum but zero depth. This is counter intuitive and causes problems if one wants to compute flow speed maps from sww files.
Change this in data_manager.py so that momentum is set to zero in sww files whenever depth is less than minimum_storable_height.
I assign this to Jane as Duncan will be busy with ticket:222
Change History (7)
comment:1 Changed 18 years ago by
| Owner: | changed from jane to ole |
|---|
comment:2 Changed 18 years ago by
| Component: | Functionality and features → Testing and validation |
|---|---|
| Owner: | changed from ole to duncan |
Done in changeset:4868 On test, however, still fails. It is test_sww2domain2 in data_manager.py which deals with NaN values in SWW. I'll pass that on onto to Duncan. Please close this ticket when the test works again.
comment:3 Changed 18 years ago by
| Owner: | changed from duncan to someone |
|---|---|
| Priority: | normal → low |
| Summary: | minimum_storable_height should also control storage of momentum → sww2domain is failing in (DISABLED)test_sww2domain2 |
I think Peter did this function. I am not aware of it being used these days...
comment:4 Changed 17 years ago by
| Cc: | duncan removed |
|---|---|
| Owner: | changed from someone to rwilson |
comment:5 Changed 16 years ago by
| Owner: | changed from rwilson to ole |
|---|
comment:6 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:7 Changed 16 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
The problem is not with depth which has been fixed for some time. However, reenabling the test revealed problems with NaN's and 'filler'.
Disabled test again, but really, this should be looked at.
I'll take this.