Opened 11 years ago

Closed 10 years ago

#242 closed defect (fixed)

auto validate, test fit and mem failing.

Reported by: duncan Owned by: ole
Priority: normal Milestone:
Component: Architecture and API Version:
Severity: normal Keywords:
Cc:

Description

the fit is using more memory than previously. Could be related to ticket#241. Indicates a memory leak.

Change History (8)

comment:1 Changed 11 years ago by duncan

  • Resolution set to wontfix
  • Status changed from new to closed

It is OK. Since generate mesh doesn't ask for as much memory as it used to, fitting has to ask for more.

comment:2 Changed 11 years ago by ole

  • Resolution wontfix deleted
  • Status changed from closed to reopened

When caching problem in ticket:302 was fixed, this problem reappeared since the fitting algorithm again has to rebuild the mesh.

Now that caching can handle objects the the best solution would be to equip domain with a mesh instance instead of inheritance and pass that object into the cached fitting call.

Passing all of the domain does not work as quantity numbers change between calls.

comment:3 Changed 11 years ago by ole

  • Owner changed from Duncan to ole
  • Status changed from reopened to new

comment:4 Changed 10 years ago by ole

Equipping domain with a Mesh object would imply a composition pattern rather than an inheritance pattern. This feels right in addition to solving the memory problem above.

comment:5 Changed 10 years ago by ole

  • Component changed from Appearance and visualisation to Architecture and API

comment:6 Changed 10 years ago by ole

See changeset:5855 for last changes in quantity.py discussing this issue.

comment:7 Changed 10 years ago by ole

The transition from inheritance to composition of the Mesh-Domain relationship was implemented in changeset:6191

comment:8 Changed 10 years ago by ole

  • Resolution set to fixed
  • Status changed from new to closed

This was completed in changeset:6196 and changeset:6197

Note: See TracTickets for help on using tickets.