Opened 12 years ago

Closed 11 years ago

#262 closed enhancement (fixed)

Implement option to calculate momentum using centroid speeds

Reported by: ole Owned by: ole
Priority: normal Milestone:
Component: Efficiency and optimisation Version:
Severity: normal Keywords:
Cc: stephen.roberts@…

Description

This calculation is currently part of the code balance_deep_and_shallow invoked by domain.tight_slope_limiters = True (see source:/anuga_core/source/anuga/shallow_water/shallow_water_domain.py).

However, if pulled out as an independent option, we can disable the gradient-limiter for momentum altogether and thus improve the overall speed of ANUGA when this option is switched on.

I understand that we may develop velocity limiters at a later point and use those to reconstruct momentum. However, this a step in that direction and will provide a further gain in computation speed.

Change History (4)

comment:1 Changed 12 years ago by ole

  • Resolution set to fixed
  • Status changed from new to closed

Done in changeset:5297

comment:2 Changed 12 years ago by ole

  • Resolution fixed deleted
  • Status changed from closed to reopened

This was really not a good idea to do in general. While it makes sense to use this approach to stabilise in very thin layers of water (as used in balance_deep_and_shallow) the method would make more sense as part of the first order scheme. I reopen the ticket to do this, while moving the centroid_velocity code back into the thin layers only.

comment:3 Changed 12 years ago by ole

General use of centroid_velocities was removed again in changeset:5315 and only used for alpha<1 as before. The only difference now is that this functionality has its own keyword, use_centroid_velocities, to be used with tight_slope_limiters for example.

comment:4 Changed 11 years ago by nariman

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.