Opened 9 years ago

Closed 9 years ago

#343 closed enhancement (fixed)

Turn Patong validation into a proper unit test

Reported by: ole Owned by: ole
Priority: normal Milestone:
Component: Testing and validation Version:
Severity: major Keywords:
Cc:

Description

Currently the Patong examples are part of the autovalidation suite, but they compare generated sww files number for number to the reference model. This is not desirable and , indeed, the tests fail.

Instead, we need to follow the methodology used for the Okushiri autovalidation where time series are compared in terms of specific features such as maxima, minima.

Look at the way Okushiri has been done and apply it to the Patong tests.

Change History (4)

comment:1 Changed 9 years ago by hudson

  • Owner changed from ole to hudson
  • Status changed from new to assigned

comment:2 Changed 9 years ago by ole

This was done in changeset:7652, changeset:7653, changeset:7666, changeset:7669 and changeset:7670.

Verified again that all validation tests ran on one node of the AIFDR cluster on 28th April 2010 using the code from anuga_1_1

nielso@node15:~/sandpit/anuga/branches/anuga_1_1/anuga_validation/automated_validation_tests$ python validate_all.py


Running all validation tests - some may take several days and some may require memory in the order of 8-16GB


Validation test suites:

./UQ_runup_2006/validate_uq_runup.py ./fitting/validate_benchmark_fit.py ./flow_tests/validate_flow.py ./okushiri_tank_validation/validate_okushiri.py ./patong_beach_validation/validate_patong_scenario.py ./urs_mux_files_validation/validate_Bf.py

python validate_uq_runup.py test_that_UQ_output_is_as_expected (main.Test_uq) ... ok


Ran 1 test in 64.475s

OK python validate_benchmark_fit.py test_fit_time_and_mem (main.Test_uq) ... ok


Ran 1 test in 9.259s

OK python validate_flow.py Exercise Ted Rigby's test of steady state flows ... ok


Ran 1 test in 1348.090s

OK python validate_okushiri.py Test that caching of set_quantity works ... ok Test that ANUGA replicates physics of the Okushiri Island ... ok


Ran 2 tests in 298.557s

OK python validate_patong_scenario.py Exercise Patong Validation Scenario for three resolutions and ... ok


Ran 1 test in 134305.822s

OK python validate_Bf.py test_compare_URSsww_vs_EvolveANUGAsww (main.Test_Bf) ... ok


Ran 1 test in 4.875s

OK That took 136032.19 seconds in total nielso@node15:~/sandpit/anuga/branches/anuga_1_1/anuga_validation/automated_validation_tests$

comment:3 Changed 9 years ago by ole

  • Owner changed from hudson to ole
  • Status changed from assigned to new

comment:4 Changed 9 years ago by ole

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.