Opened 10 years ago

Closed 10 years ago

#317 closed enhancement (fixed)

Event selection and build_boundary integration

Reported by: rwilson Owned by: rwilson
Priority: high Milestone:
Component: Architecture and API Version:
Severity: normal Keywords:
Cc:

Description (last modified by ole)

Currently the EventSelection tool generates a python fragment containing MUX filenames and the global weight, in the hope that the generated module would be used in build_boundary.py.

A better approach would be to modify build_boundary.py to get urs2sts() to take the older generated event_<event#>.list file which already contains the MUX filenames and weight. The approach would be to remove the existing 'urs_filenames' and 'weight' parameters and replace them with a full path to the *.list file plus the 'base' path to the MUX files.

Changes to build_boundary.py should be made with a view to eventually including the code into ANUGA proper, which means removing any reference to project-specific values and passing them in as a parameter.

Note that any code existing outside ANUGA may have references to Numeric that must be changed when ANUGA goes to numpy.

Change History (4)

comment:1 Changed 10 years ago by rwilson

  • Description modified (diff)
  • Owner changed from Ross Wilson to rwilson
  • Status changed from new to assigned

comment:2 Changed 10 years ago by ole

It might be worth considering leaving the underlying function urs2sts as it is and implement the high level integration of data from the event selector (as described above) in a wrapper that could have a name such as

def build_urs_boundary(mux_directory, event_file, output_directory):

...

where mux_directory is the location of the URS generated mux files (normally obtained from the environment variable $MUXHOME/mux) and event_file the unit source filenames and associated weights generated e.g. by the event selector.

The function build_urs_boundary would be responsible for creating the STS boundary file and storing it (and the derived gauge csv data) in the specified output_directory in a sub directory somehow identified by the event code.

comment:3 Changed 10 years ago by ole

  • Description modified (diff)

comment:4 Changed 10 years ago by rwilson

  • Resolution set to fixed
  • Status changed from assigned to closed

EventSelection? data now automatically included in project.py (and other files).

This area of ANUGA will have ongoing changes.

Note: See TracTickets for help on using tickets.